Add split one token into several (resolves #2838) #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ines
added
enhancement
honnibal
reviewed
Feb 12, 2019
|
Thanks a lot for this! It'll be a really useful change. The main question remaining is whether we want the API to take an index, or a |
Change retokenizer.split() to use a Token object, instead of an index.
Tweak retokenize.split() API so that we pass the `Token` object, not the index.
|
I think there was a small problem before -- the I also went ahead and made the change to the |
|
Sorry, I didn't see your input. Thank you for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the capacity to split tokens
Description
Implemented the feature as described in #2838. I added several error messages, and a new test suite for the functionality.
The tests passed with 554 warnings, but I think this is not related to this change.
Does this change require new documentation?
Types of change
New feature and new tests.
Checklist